Use correct jgit artifact

[leonardehrenfried]

This PR introduces org.eclipse.jgitas the main artifact for use in this plugin.

I cannot find any information on what org.eclipse.jgit.pgm is but it includes a large amount of unnecessary dependencies like the servlet API, jetty and other things that this plugin definitely doesn't need.

[bchazalet]

That looks awesome!

[leonardehrenfried]

Hmm, the JVM seemed to have crashed during the test job. I'm going to rerun it.

[leonardehrenfried]

Hmm, the JVM still crashes. Does anybody know what this could mean:

Downloading sbt launcher for 0.13.16-M1:
  From  http://repo.typesafe.com/typesafe/ivy-releases/org.scala-sbt/sbt-launch/0.13.16-M1/sbt-launch.jar
    To  /home/travis/.sbt/launchers/0.13.16-M1/sbt-launch.jar
*** buffer overflow detected ***: java terminated
======= Backtrace: =========
/lib/x86_64-linux-gnu/libc.so.6(__fortify_fail+0x37)[0x7ff6f76bcdb7]
/lib/x86_64-linux-gnu/libc.so.6(+0x10bcb0)[0x7ff6f76bbcb0]
/usr/lib/jvm/java-7-openjdk-amd64/jre/lib/amd64/libnet.so(Java_java_net_Inet4AddressImpl_getLocalHostName+0x190)[0x7ff6db11d8e0]
[0x7ff6ed014e98]

[leonardehrenfried]

Okay, the newer version of the artifact doesn't work with Java 7. I'm going to be using an older version of the artifact that has been compiled with Java 7.

Why is Java 7, which has been EOL since April 2015, required?

[bchazalet]

@leonardehrenfried I don't think you're getting the same error in travis now, do you? It looks like it's a java.lang.UnsupportedClassVersionError: org/eclipse/jgit/storage/file/FileRepositoryBuilder : Unsupported major.minor version 52.0

[bchazalet]

We didn't want to force java 8 on our users, at least without releasing a newest version for java 7 (that's 0.9.x). But, in my opinion, we could now switch to java 8. @hseeberger what do you think?

[leonardehrenfried]

@bchazalet I hadn't committed the fix yet. The build is running now.

[leonardehrenfried]

Bintray is very slow today. :(

[error] SERVER ERROR: Internal Server Error url=https://repo.typesafe.com/typesafe/ivy-releases/org.scala-sbt/sbt-launch/0.13.16-M1/ivys/ivy.xml
[warn] problem while downloading module descriptor: https://repo.typesafe.com/typesafe/ivy-releases/org.scala-sbt/sbt-launch/0.13.16-M1/ivys/ivy.xml: The HTTP response code for https://repo.typesafe.com/typesafe/ivy-releases/org.scala-sbt/sbt-launch/0.13.16-M1/ivys/ivy.xml did not indicate a success. See log for more detail. (13454ms)

I'm going to try again.

[leonardehrenfried]

This is getting very annoying:

[FAILED     ] org.scala-sbt#interface;0.13.16-M1!interface.jar: The HTTP response code for https://repo.typesafe.com/typesafe/ivy-releases/org.scala-sbt/interface/0.13.16-M1/jars/interface.jar did not indicate a success. See log for more detail. (22572ms)

[leonardehrenfried]

Closed and reopened in order to trigger a rebuild on travis.

[leonardehrenfried]

Again, retrigger travis build.

[leonardehrenfried]

I give up. Something is wrong with bintray.

[dvic]

Wow, is bintray having these problems often? Downloading a 252 kb jar takes 40 seconds:

[SUCCESSFUL ] org.scala-sbt#compile;0.13.16-M1!compile.jar (40274ms)

(taken from current build on TravisCI)

[leonardehrenfried]

I have no hard data but to me bintray "feels" slower than Maven Central.

https://travis-ci.org/sbt/sbt-git/builds/233559905 has been resolving and downloading dependencies for ~30 minutes.

[dwijnand]

I have 1 comment, but it's not a blocker.

[dwijnand]

Can we use sudo: false? I.e the fast docker containers?

[leonardehrenfried]

Sure we can.

[leonardehrenfried]

Build also passes with sudo:false.

[dwijnand]

Thanks, @leonardehrenfried.