Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/build info values #89

Merged
merged 1 commit into from
May 12, 2016
Merged

Feature/build info values #89

merged 1 commit into from
May 12, 2016

Conversation

jastice
Copy link
Contributor

@jastice jastice commented May 2, 2016

Adds buildInfoValues task, which exposes the set of BuildInfoResult objects used by sbt-buildinfo to generate BuildInfo files.
This can be used within the sbt build itself to add the build info to the jar Manifest.

…t` objects used by sbt-buildinfo to generate BuildInfo files.

This can be used within the sbt build itself to add the build info to the jar Manifest.
@jastice jastice mentioned this pull request May 2, 2016
@eed3si9n
Copy link
Member

eed3si9n commented May 2, 2016

LGTM

@jastice
Copy link
Contributor Author

jastice commented May 12, 2016

Will you do a merge/release or can I help you with it?

@eed3si9n eed3si9n merged commit 489215b into sbt:master May 12, 2016
@jastice
Copy link
Contributor Author

jastice commented May 12, 2016

Thanks!

@jastice jastice deleted the feature/buildInfoValues-squash branch May 12, 2016 15:01
@eed3si9n
Copy link
Member

I think there still some pending issues that needs to be fixed before a release.
In particular #88 I think needs to be addressed.

@jastice
Copy link
Contributor Author

jastice commented May 12, 2016

I'll have a look if I can do something about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants