Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproduce 211 #212

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Reproduce 211 #212

merged 1 commit into from
Nov 9, 2024

Conversation

eed3si9n
Copy link
Member

@eed3si9n eed3si9n commented Nov 9, 2024

Fixes #211

@mzuehlke
Copy link

mzuehlke commented Nov 9, 2024

I have the hunch the error is here: https://github.com/sbt/sbt-buildinfo/pull/208/files#diff-dfebc867528f461dff8d9efe9dac4968b71c28a4efde8c7bd7f5b46371cc5997R40-R41

it got changed from:

extracted getOpt (key in scope(key, project)) map (v => task(ident(key) -> v))

to

extracted.getOpt(project / key).map((v) => task(ident(key) -> v))

but correct would be

extracted getOpt (scope(key, project) / key) map (v => task(ident(key) -> v))

As @adpi2 did in his abandoned PR: https://github.com/sbt/sbt-buildinfo/pull/207/files#diff-dfebc867528f461dff8d9efe9dac4968b71c28a4efde8c7bd7f5b46371cc5997L34-L35

@eed3si9n
Copy link
Member Author

eed3si9n commented Nov 9, 2024

Yea, it seems like I didn't implement / for scope.

@eed3si9n eed3si9n marked this pull request as ready for review November 9, 2024 08:56
@eed3si9n eed3si9n merged commit 07337b5 into develop Nov 9, 2024
6 checks passed
@eed3si9n eed3si9n deleted the wip/repro211 branch November 9, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generate incorrect value since 0.13.0
2 participants