New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use local timezone strings for buildAtString #156

Merged

eed3si9n merged 1 commit into sbt:master from xerial:local-timezone

Feb 19, 2020

Contributor

xerial commented Feb 12, 2020 •

edited

Loading

buildAtString needs to clarify the timezone by adding Z to the date formatter. Having timezone information is generally a good practice to avoid confusion.
I chose the local time zone string instead of UTC so that we don't need to translate UTC timezone into our local time zone in our head.
If we need to have UTC representation, buildAtMillis (since 1970-01-01 UTC) still can be used to generate UTC datetime strings.


          Append local timezone info to buildAtString

b8b7b61

eed3si9n approved these changes

View reviewed changes

eed3si9n merged commit 0a57d6a into sbt:master

leviramsey mentioned this pull request

Replace java.util.Date with java.time.Instant #157

Merged

eed3si9n added this to the 0.10.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet