Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix newFileSystem use the URI with a non-existent path #525

Merged
merged 2 commits into from
May 6, 2024

Conversation

Roiocam
Copy link

@Roiocam Roiocam commented Apr 29, 2024

Motivation

Resolves: #486, #503

FileSystems don't allow you to pass the URI with a non-existent path.

@Roiocam
Copy link
Author

Roiocam commented Apr 29, 2024

@eed3si9n Would you like to take a look?

@Roiocam
Copy link
Author

Roiocam commented Apr 29, 2024

Rollback the environment settings, test was passed locally

[info] [info] Jar hash: 388d649fe782c46ccfd19feff99b9b7a8f6a6d7e
[info] [success] Total time: 26 s, completed 2024-4-29 19:21:40
[info] [success] Total time: 2 s, completed 2024-4-29 19:21:41
[info] + shading/unmanagedjars 
[success] Total time: 950 s (15:50), completed 2024-4-29 19:21:43

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit 573579b into sbt:develop May 6, 2024
4 checks passed
@Roiocam Roiocam deleted the fix-no-such-file branch May 6, 2024 07:41
@jrdegreeff
Copy link

This changes fixes the exact problem I am running into right now. Is there a plan for a release any time soon to publish this?

dongjoon-hyun pushed a commit to apache/spark that referenced this pull request Oct 15, 2024
### What changes were proposed in this pull request?
The pr aims to upgrade `sbt-assembly` from `2.2.0` to `2.3.0`

### Why are the changes needed?
- `sbt-assembly`, the full release notes: https://github.com/sbt/sbt-assembly/releases/tag/v2.3.0
- Bug fixed:
  Fixes assembly not creating parent directories by Roiocam in sbt/sbt-assembly#525
  Throws error when a misconfigured assemblyOutputPath is detected by hygt in sbt/sbt-assembly#523

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Pass GA.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes #48409 from panbingkun/SPARK-49922.

Authored-by: panbingkun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
himadripal pushed a commit to himadripal/spark that referenced this pull request Oct 19, 2024
### What changes were proposed in this pull request?
The pr aims to upgrade `sbt-assembly` from `2.2.0` to `2.3.0`

### Why are the changes needed?
- `sbt-assembly`, the full release notes: https://github.com/sbt/sbt-assembly/releases/tag/v2.3.0
- Bug fixed:
  Fixes assembly not creating parent directories by Roiocam in sbt/sbt-assembly#525
  Throws error when a misconfigured assemblyOutputPath is detected by hygt in sbt/sbt-assembly#523

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Pass GA.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes apache#48409 from panbingkun/SPARK-49922.

Authored-by: panbingkun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assembly no longer creating directories defined in assemblyOutputPath
3 participants