Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Jar Jar Abrams 1.13.0 #509

Merged
merged 2 commits into from
Oct 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,23 @@ jobs:
shell: bash
run: |
sbt -v clean scripted

ea-test:
runs-on: ubuntu-latest
env:
# define Java options for both official sbt and sbt-extras
JAVA_OPTS: -Xms2048M -Xmx2048M -Xss6M -XX:ReservedCodeCacheSize=256M -Dfile.encoding=UTF-8
JVM_OPTS: -Xms2048M -Xmx2048M -Xss6M -XX:ReservedCodeCacheSize=256M -Dfile.encoding=UTF-8
steps:
- uses: actions/checkout@v4
- name: Setup JDK
uses: actions/setup-java@v3
with:
java-version: 22-ea
distribution: temurin
jdkFile: https://download.java.net/java/early_access/jdk22/20/GPL/openjdk-22-ea+20_linux-x64_bin.tar.gz
cache: sbt
- name: Build and test
shell: bash
run: |
sbt -v clean scripted
2 changes: 1 addition & 1 deletion build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ lazy val root = (project in file("."))
name := "sbt-assembly"
scalacOptions := Seq("-deprecation", "-unchecked", "-Dscalac.patmat.analysisBudget=1024", "-Xfuture")
libraryDependencies ++= Seq(
"com.eed3si9n.jarjarabrams" %% "jarjar-abrams-core" % "1.9.0",
"com.eed3si9n.jarjarabrams" %% "jarjar-abrams-core" % "1.13.0",
)
(pluginCrossBuild / sbtVersion) := {
scalaBinaryVersion.value match {
Expand Down
6 changes: 5 additions & 1 deletion src/main/scala/sbtassembly/Assembly.scala
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,11 @@ object Assembly {
if (shadeRules.isEmpty)
(name: String, inputStream: LazyInputStream) => Some(name -> inputStream)
else {
val bytecodeShader = Shader.bytecodeShader(shadeRules, verbose = false)
val bytecodeShader = Shader.bytecodeShader(
shadeRules,
verbose = false,
skipManifest = false,
)
(name: String, inputStream: LazyInputStream) => {
val is = inputStream()
val shadeResult = bytecodeShader(Streamable.bytes(is), name)
Expand Down