Deprecate CrossVersion.Disabled (was make CrossVersion.Disabled stable) #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes sbt/sbt#4975 This makes `CrossVersion.Disabled` a stable identifier by reverting `final def` back to `final val`. This is to fix Scala.JS build ``` [error] ScalaJSCrossVersion.scala:34:23: stable identifier required, but sbt.`package`.CrossVersion.Disabled found. [error] case CrossVersion.Disabled => [error] ^ [error] one error found [error] (Compile / compileIncremental) Compilation failed ``` ### notes - sbt#121 added `final val Disabled = sbt.librarymanagement.Disabled` but it was just a companion object - sbt#280 actually made it `final val Disabled = sbt.librarymanagement.Disabled()`, but this broke Cat's build that was calling `CrossVersion.Disabled()` - sbt#290 changed to `final def Disabled = sbt.librarymanagement.Disabled` and `object Disabled extends sbt.librarymanagement.Disabled` - This changes back to `final val Disabled = sbt.librarymanagement.Disabled` (but because we changed the companion object in sbt#290 that's ok)
dwijnand
approved these changes
Aug 22, 2019
|
Given that |
eed3si9n
added a commit
to eed3si9n/librarymanagement
that referenced
this pull request
Aug 28, 2019
sbt#316 started returning Disabled companion object for `apply()` instead of creating a new instance. This leaked into JSON as it uses runtime types for union. This works around that by providing a hand-crafted format. Ref sbt/sbt#4997
eed3si9n
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migration note
CrossVersion.Disableddid not work as expected in sbt 1.0.x ~ 1.2.x.We recommend using
CrossVersion.disabledinstead. For pattern matching, you can either check equality withCrossVersion.disabledor type match withcase _: sbt.librarymanagement.Disabled.original PR
Fixes sbt/sbt#4975
Fixes sbt/sbt#4977
This makes
CrossVersion.Disableda stable identifier by revertingfinal defback tofinal val.This is to fix Scala.JS build
notes
final val Disabled = sbt.librarymanagement.Disabledbut it was just a companion objectfinal val Disabled = sbt.librarymanagement.Disabled(), but this broke Cat's build that was callingCrossVersion.Disabled()final def Disabled = sbt.librarymanagement.Disabledandobject Disabled extends sbt.librarymanagement.Disabledfinal val Disabled = sbt.librarymanagement.Disabled(but because we changed the companion object in make object Disabled extend Disabled #290 that's ok)