This repository has been archived by the owner on Dec 8, 2023. It is now read-only.
Make aio::Gateway struct fields public #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For consistency with the synchronous version (rust_igd::Gateway), rust_igd::aio::Gateway struct fields should be public too.
|
Hey! I don't think there was a particular reason, it's just an oversight. I'll cut you another release! |
|
Thanks for the fast response! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency with the synchronous version (
rust_igd::Gateway),rust_igd::aio::Gatewaystruct fields should be public too. I don't know if there was any specific reason to make them private though, but a user needs to have access to the gateway address (e.g. to find their IP on LAN).