-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom_get_name
config option
#889
Conversation
for more information, see https://pre-commit.ci
@sbrunner ok! I finally got a chance to fix this up. The pull request checks are failing because my commits dont start with a capital letter. I think everything else is passing ( I've removed all by manual edits from I couldn't make So instead I made
Let me know what you think! |
That looks good to me :-) |
@sbrunner awesome! could we release it as new version? The one failing check is this: "requests.exceptions.HTTPError: 401 Client Error: Unauthorized for url: https://api.github.com/repos/sbrunner/jsonschema-gentypes/pulls/889/commits" I think that's a spurious error maybe? |
Released in version 2.6.0 |
@sbrunner woohoo! thanks so much! |
Attached is what I'm thinking for a way to allow individual users of the library to pass their own
get_name
method.In case they want to have generated python class types like
SubresourceUri
instead of just the default.title()
version ofSubresourceuri
#843
NOTE: we'll need to swap
get_name
toself.get_name
on all subclasses ofAPI
before we can merge this repo. I only didAPI
andAPIv4
so far.