Fix lock encryption key retrieval #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
reviewed
May 23, 2024
huyuwei1996
reviewed
May 23, 2024
bdraco
reviewed
May 23, 2024
|
Looks good. Once last tweak request above. Its getting close to midnight so I'll test this in the morning when I wake up and get a new release done tomorrow if everything works as expected. Thanks! |
bdraco
added a commit
to home-assistant/core
that referenced
this pull request
May 23, 2024
20 tasks
|
Sadly, the batteries are dead in my Test lock so I'll have to go to the store to get new ones |
|
found compatible batteries in another device. testing now |
bdraco
approved these changes
May 23, 2024
bdraco
reviewed
May 23, 2024
|
Thanks @dsypniewski |
bdraco
reviewed
May 23, 2024
balloob
pushed a commit
to home-assistant/core
that referenced
this pull request
May 24, 2024
* Update pySwitchbot to 0.46.0 to fix lock key retrieval needs sblibs/pySwitchbot#236 * bump * fixes
frenck
pushed a commit
to home-assistant/core
that referenced
this pull request
May 24, 2024
* Update pySwitchbot to 0.46.0 to fix lock key retrieval needs sblibs/pySwitchbot#236 * bump * fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that SwitchBot has made some changes to their accounts and the previous key retrieval method doesn't work for everybody. This is based on @alexschultze and @hsakoh research, and verified myself with the SwitchBot Android application code.
Since cognito authentication is no longer used I also removed the boto3 dependency.
Fixes #234
Edit: I noticed only after creating this PR that there already is one addressing the exact same issue #235