Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix position controller bugs #97

Merged
merged 12 commits into from
Nov 1, 2024
Merged

Conversation

Tacha-S
Copy link
Contributor

@Tacha-S Tacha-S commented Sep 18, 2024

Change Summary

  • Execute calibration on configure.
  • Wait for controller's command.
  • Do not accept a command over the limits.
  • Load joint_type and position limit from URDF.

Details

Impacts

References

Additional Information

@Tacha-S
Copy link
Contributor Author

Tacha-S commented Sep 19, 2024

The issue with jerky motion due to control cycle problems still remains, but it's functioning for now.

@Tacha-S Tacha-S marked this pull request as draft October 9, 2024 09:21
@Tacha-S Tacha-S force-pushed the bugfix/position-controller branch from ecd15c4 to 23fc0f3 Compare October 11, 2024 04:46
@Tacha-S Tacha-S marked this pull request as ready for review October 11, 2024 06:51
@Tacha-S Tacha-S requested review from jsupratman13 and nyxrobotics and removed request for jsupratman13 and nyxrobotics October 11, 2024 06:52
@Tacha-S Tacha-S force-pushed the bugfix/position-controller branch from d3e091c to 4cc4b18 Compare October 31, 2024 09:21
vesc_hw_interface/README.md Show resolved Hide resolved
vesc_hw_interface/src/vesc_hw_interface.cpp Outdated Show resolved Hide resolved
@Tacha-S Tacha-S marked this pull request as draft November 1, 2024 09:05
@Tacha-S Tacha-S marked this pull request as ready for review November 1, 2024 09:08
@Tacha-S Tacha-S requested a review from jsupratman13 November 1, 2024 09:08
@jsupratman13 jsupratman13 merged commit 1f9ce4f into jazzy-devel Nov 1, 2024
@jsupratman13 jsupratman13 deleted the bugfix/position-controller branch November 1, 2024 09:20
@nyxrobotics nyxrobotics mentioned this pull request Jan 23, 2025
saitenntaisei added a commit that referenced this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants