Fix cyclic ref

[sbcgua]

No description provided.

[sbcgua]

@larshp The exception does not refer to ZIF_AJSON anymore but the error is still there ... looks like some bug.

[larshp]

hmm, yea, its broken

[larshp]

just disable the rule for now, the interfaces are cyclic anyhow, but will probably work in the merged report

[sbcgua]

@larshp Ok, I picked the fix to the master, but left this PR open. Currently it contains just the setting to enable cyclic check, so it can be restarted and merged later when the issue is fixed

[larshp]

reported cycle fixed with abaplint/abaplint#2822

[sbcgua]

Now it is filter and mapping interfaces, they refer to types defined in zif_ajson (ty_node in particular). Hmm. Honestly speaking, semantically, the types are in a good place. Yet technically they create a cyclic ref. Maybe it makes sense to separate ty_node and Ko to zif_ajson_types or similar.

Any serious impact on AG or other tools you maintain ? @larshp @mbtools @albertmink @jrodriguez-rc

[larshp]

if its all good, design wise, just exclude one of the interfaces from the rule

[mbtools]

Minimal impact on my projects.

[jrodriguez-rc]

No impact from my side

[albertmink]

No, it is fine.

[sbcgua]

Ok, so most of types (except ty_opts) were move to zif_ajson_types. cyclic_ref rule re-enabled.

Let's hope nothing breaks ... merging