Poem Splitter #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbahaud
reviewed
Mar 28, 2021
| @@ -0,0 +1,5 @@ | |||
| //Splits string containing poem into array of lines | |||
| function splitPoem(poem) { | |||
There was a problem hiding this comment.
Not sure if this is required in the client. The server is probably going to get the uploaded poem as a json, do the split and save it to datastore. Please sync with colin on the server poem upload endpoint that he is working on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS file created with a function that takes an input string (the poem that needs to be split), splits it by new line character, places each line into an array, and returns the array.