-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parameters for Gitlab 8 #236
base: master
Are you sure you want to change the base?
Conversation
Remove deprecated parameters moved a long time ago out of gitlab.yml into Application Settings UI (GitLab 7.7) and the Services Templates (GitLab 7.8): gitlab_support_email, gitlab_projects, gitlab_restricted_visibility_levels, gitlab_default_projects_features_wall, gitlab_default_projects_features_visibility_level, issues_tracker, company_logo_url, company_link, company_name
Here's a first version. I'm successfully managing instances running GitLab 7.13 or 8.1 with this, including advanced settings such as Kerberos and Omniauth. However I'm lacking time to make lint happy and adjust the tests (some defaults changed and indentation may be a bit different in config files as I used more recent config templates provided by GitLab); any help would be very welcome in this area. To deploy GitLab 8+, make sure to specify a branch for gitlab_git_http_server in order to install this required dependency (but don't install it with GitLab 7.X, Git HTTP access wouldn't work anymore)
|
Cf. https://gitlab.com/gitlab-org/gitlab-workhorse We might as well use the new name right now. Add a symlink from git-http-server to preserve compatibility with GitLab 8.0 and 8.1.
file { "${git_home}/gitlab/public/uploads": | ||
ensure => $gitlab_uploads_path_type, | ||
target => $gitlab_uploads_folder, | ||
mode => '0755', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this is meant to be 0750
. See https://github.com/gitlabhq/gitlabhq/blob/3f05c22f5612c26ff3707aa16eb0f3c8be18ec93/lib/tasks/gitlab/check.rake#L297
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. The module was using 0755 until now, but changing to 0750 to pass rake check
Other features:
into Application Settings UI (GitLab 7.7) and the Services Templates
(GitLab 7.8):
gitlab_support_email, gitlab_projects,
gitlab_restricted_visibility_levels,
gitlab_default_projects_features_wall,
gitlab_default_projects_features_visibility_level, issues_tracker,
company_logo_url, company_link, company_name
Fixes #234 and #235