Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameters for Gitlab 8 #236

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

alexcern
Copy link
Contributor

Other features:

  • logrotate template to correctly handle logrotate config when not using default git_home
  • gitlab_uploads_folder to customize location of uploads
  • updated defaults and config files to match values recommended for GitLab nowadays (as per GitLab support files)
  • support kerberos authentication with dedicated port (EE only)
  • remove deprecated parameters moved a long time ago out of gitlab.yml
    into Application Settings UI (GitLab 7.7) and the Services Templates
    (GitLab 7.8):

gitlab_support_email, gitlab_projects,
gitlab_restricted_visibility_levels,
gitlab_default_projects_features_wall,
gitlab_default_projects_features_visibility_level, issues_tracker,
company_logo_url, company_link, company_name

Fixes #234 and #235

Remove deprecated parameters moved a long time ago out of gitlab.yml
into Application Settings UI (GitLab 7.7) and the Services Templates
(GitLab 7.8):

gitlab_support_email, gitlab_projects,
gitlab_restricted_visibility_levels,
gitlab_default_projects_features_wall,
gitlab_default_projects_features_visibility_level, issues_tracker,
company_logo_url, company_link, company_name
@alexcern
Copy link
Contributor Author

Here's a first version.

I'm successfully managing instances running GitLab 7.13 or 8.1 with this, including advanced settings such as Kerberos and Omniauth. However I'm lacking time to make lint happy and adjust the tests (some defaults changed and indentation may be a bit different in config files as I used more recent config templates provided by GitLab); any help would be very welcome in this area.

To deploy GitLab 8+, make sure to specify a branch for gitlab_git_http_server in order to install this required dependency (but don't install it with GitLab 7.X, Git HTTP access wouldn't work anymore)

class { 'gitlab':
  ensure => 'present',
  gitlab_branch => 'v8.1.2',
  gitlab_git_http_server_branch => '0.3.0',
}

@alexcern alexcern mentioned this pull request Oct 28, 2015
file { "${git_home}/gitlab/public/uploads":
ensure => $gitlab_uploads_path_type,
target => $gitlab_uploads_folder,
mode => '0755',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The module was using 0755 until now, but changing to 0750 to pass rake check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants