Skip to content

Commit

Permalink
test/connectivity: Remove explicit namespace in policy labels
Browse files Browse the repository at this point in the history
As the connectivity test can be from another namespace, which is passed
by --test-namespace CLI flag, we should not have any hard coded namespace
in all related policy manifests.

The namespace label is automatically added as part of cilium#330, so we don't
need to hard code it in match labels.

Related: cilium#1112

Signed-off-by: Tam Mach <[email protected]>
  • Loading branch information
sayboras committed Sep 28, 2022
1 parent e206203 commit ed32c0d
Show file tree
Hide file tree
Showing 7 changed files with 0 additions and 9 deletions.
3 changes: 0 additions & 3 deletions connectivity/manifests/client-egress-only-dns.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,8 @@ spec:
- matchPattern: "*"
toEndpoints:
- matchLabels:
io.kubernetes.pod.namespace: kube-system
k8s-app: kube-dns
- matchLabels:
io.kubernetes.pod.namespace: kube-system
k8s-app: coredns
- matchLabels:
io.kubernetes.pod.namespace: kube-system
k8s-app: node-local-dns
1 change: 0 additions & 1 deletion connectivity/manifests/client-egress-to-echo-deny.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,4 @@ spec:
protocol: TCP
toEndpoints:
- matchLabels:
io.kubernetes.pod.namespace: cilium-test
kind: echo
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,4 @@ spec:
protocol: TCP
toEndpoints:
- matchLabels:
io.kubernetes.pod.namespace: cilium-test
kind: echo
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,4 @@ spec:
protocol: TCP
fromEndpoints:
- matchLabels:
io.kubernetes.pod.namespace: cilium-test
name: client
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,4 @@ spec:
protocol: TCP
toEndpoints:
- matchLabels:
io.kubernetes.pod.namespace: cilium-test
kind: echo
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,4 @@ spec:
protocol: TCP
toEndpoints:
- matchLabels:
io.kubernetes.pod.namespace: cilium-test
kind: echo
1 change: 0 additions & 1 deletion connectivity/manifests/client-egress-to-echo.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ spec:
protocol: TCP
toEndpoints:
- matchLabels:
io.kubernetes.pod.namespace: cilium-test
kind: echo
- toPorts:
- ports:
Expand Down

0 comments on commit ed32c0d

Please sign in to comment.