Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes #672 add unwrap option and pass it to Gyoku #673

Merged
merged 1 commit into from
Mar 11, 2015

Conversation

TiteiKo
Copy link
Contributor

@TiteiKo TiteiKo commented Mar 9, 2015

So, this is a PR to fix this issue : #672

It depends on the merge of this PR on Gyoku : savonrb/gyoku#52, based on @stgwilli's work.

It adds an option :unwrap to Savon::Client to be passed to Gyoku, to be able to have this

a = { items: [ { item: { name: 'foo' } }, { item: { name: 'bar' } ] }

render this

<items><item><name>foo</name></item><item><name>bar</name></item></items>

instead of this

<items><item><name>foo</name></item></items><items><item><name>bar</name></item></items>

without breaking the actual behaviour.

@tjarratt
Copy link
Contributor

Whoops -- I had forgot this was necessary to pass through, since Savon doesn't normally expose its options. I'm more than happy to merge this feature.

tjarratt added a commit that referenced this pull request Mar 11, 2015
closes #672 add unwrap option and pass it to Gyoku
@tjarratt tjarratt merged commit fba39c6 into savonrb:master Mar 11, 2015
@tjarratt
Copy link
Contributor

Released Savon v2.10.1 just now, which includes this change. Thanks so much!

@joenas
Copy link

joenas commented Apr 10, 2015

Please add this to documenation, cause I had lots of trouble finding this option! Unless I'm very bad at looking and its already there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants