Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade notes on ssl_verify_mode #1013

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Upgrade notes on ssl_verify_mode #1013

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion UPGRADING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,19 @@ will send the following cookies:
"accept=application/json; some-cookie=foo; empty-cookie=; HttpOnly"
```

### ssl_verify_mode

The `ssl_verify_mode` option now expects an [OpenSSL::SSL::](https://ruby-doc.org/3.2.2/exts/openssl/OpenSSL/SSL.html) constant. Previously, HTTPI would allow the passing of a symbol like `:none` or `:peer`.

```ruby
ssl_verify_mode: :none
```

should now be written as:

```ruby
ssl_verify_mode: OpenSSL::SSL::VERIFY_NONE
```

### adapters
Savon's adapters option now forwards adapter names and options to faraday.
Expand All @@ -61,4 +74,4 @@ client = Savon.client(
adapter: [:typhoeus, {connect_timeout: 10}]
)
```
Would create a savon client using the typhoeus adapter with a connect_timeout of 10 seconds.
Would create a savon client using the typhoeus adapter with a connect_timeout of 10 seconds.