-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
savon 2 requires nokogiri 1.6.0 which does not support ruby-1.8.7 #468
Comments
not really. savon 2.x requires nokogiri >= 1.4.0. |
we may need to disallow installing nokogiri 1.6.0 on 1.8.7 though. at least because the default is to install the newest version. you should be able to add nokogiri to your gemfile and limit the nokogiri version to something like <= 1.5 for now. |
If bundler does not support something like gem 'nokogiri', '>= 1.4.0 < 1.6.0' then yes, there are two options.
Yes, I did that. But I decided to report anyway, so that you could mention this in the README. |
glad you were already able to work around this. hope it helps other while i figure out a solution. |
nokogiri 1.6 dropped support for ruby 1.8.
thanks again for reporting this. this will be fixed with v2.3.0. |
Now if I have a bundle that has been using nokogiri 1.6.0 for some time now I will have to downgrade or fork savon to get this to work with 2.3.0. This seems like an unfortunate choice. |
either way, this is going to cause problems. since savon version 2 is supposed to work with ruby 1.8, it doesn't really make sense to allow a dependency that doesn't. imagine everyone installing savon on 1.8 getting nokogiri 1.6 and running into this problem versus using a slightly older but stable version of nokogiri. |
I don't think savon should take responsibility for locking down the dependency if it actually does support the latest nokogiri 1.6 on the vast majority of rubies except ruby 1.8: there should simply be a note in the README instead. We have other dependencies on ruby 1.9 that were already using nokogiri 1.6. I realize savon 2 must support ruby 1.8; but it can still work without being heavy-handed and locking down everyone else. (I haven't seen many other gems do this.) This error is actually a limitation of rubygems that just needs to be handled with a little manual effort... |
+1 @avit If someone want use savon with ruby 1.8 then should lock nokogiri version < '1.6' in its Gemfile. There could be just info in README about this. |
continued at #487. |
- Remove nokogiri < 1.6 in gemspec so we can resolve conflicts with fog's requirements for 1.6.0. Savon only kept the requirement for ruby 1.8 compatibility which we do not care bout.
$ bundle
...
Installing nokogiri (1.6.0)
Gem::InstallError: nokogiri requires Ruby version >= 1.9.2.
An error occurred while installing nokogiri (1.6.0), and Bundler cannot continue.
Make sure that
gem install nokogiri -v '1.6.0'
succeeds before bundling.The text was updated successfully, but these errors were encountered: