Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting HTTPI.log_level doesn't have an effect on anything #53

Closed
betelgeuse opened this issue May 12, 2012 · 2 comments
Closed

Setting HTTPI.log_level doesn't have an effect on anything #53

betelgeuse opened this issue May 12, 2012 · 2 comments
Milestone

Comments

@betelgeuse
Copy link

The documentation tells you that you can do the following to set log level:

HTTPI.log_level = :warn

The problem is that log_level does not get used anywhere. There is only one place that calls HTTPI.log and that is HTTPI.with_adapter. There log gets called with the explicit :debug level.

I see two options here:

  1. Change HTTPI.with_adapter to rely on the configured log level
  2. Remove log_level support and document that :default always gets used

Which way should we go?

rubiii added a commit that referenced this issue Jun 7, 2012
@rubiii
Copy link
Contributor

rubiii commented Jun 7, 2012

i changed HTTPI.log to use HTTPI.log_level. thanks.

@rubiii rubiii closed this as completed Jun 7, 2012
@runa
Copy link

runa commented Nov 1, 2012

Using 1.1.1 I had to do set
HTTPI.logger.level = Logger::Severity::ERROR

to get rid of the default debug msg.

Thanks for httpi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants