Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Net::HTTP adapter should support more HTTP methods #152

Closed
lgustafson opened this issue Jul 15, 2015 · 1 comment
Closed

Net::HTTP adapter should support more HTTP methods #152

lgustafson opened this issue Jul 15, 2015 · 1 comment

Comments

@lgustafson
Copy link
Contributor

When using the Net::HTTP adapter, several "non-standard" HTTP methods (such as PATCH) cause exceptions to be raised when calling HTTPI#request. The adapter only allows "standard" methods to be used. However, in Ruby 1.9.3 and later, PATCH and other methods are officially supported in Net::HTTP. I propose that the adapter should use reflection on Net::HTTP to determine if a specific method is available.

PATCH in particular is frequently used in RESTful APIs so the inability to use it via HTTPI + Net::HTTP when it is supported upstream is problematic.
lgustafson pushed a commit to lgustafson/httpi that referenced this issue Jul 15, 2015
Dynamically determine methods Net::HTTP supports with tests for PATCH…
52918e2 
… (see issue savonrb#152)
@rogerleite
Copy link
Member

Hi @lgustafson! This is awesome. Open a Pull Request and i'll merge.

@lgustafson lgustafson mentioned this issue Jul 15, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rogerleite @lgustafson