ASN1_TIME_to_tm not implemented in LibreSSL #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
jcourreges
added a commit
to jcourreges/ocaml-ssl
that referenced
this pull request
Jan 23, 2022
In savonet/pull/75 detection was implemented with a simple a macro in openssl-1.1.1m (and probably earlier versions) so using an Use dune-configurator to detect ASN1_TIME_to_tm() availability. ASN1_TIME_to_tm() is not available in LibreSSL yet mostly because it wasn't on the radar as a public function used by other projects. Hopefully it should become available in the next LibreSSL releases.
jcourreges
added a commit
to jcourreges/ocaml-ssl
that referenced
this pull request
Jan 23, 2022
In savonet/pull/75 detection was implemented with an #ifdef check. However ASN1_TIME_to_tm() was never available as a macro in openssl-1.1.X release, so a simple #ifdef check will never succeed. Instead, use dune-configurator to detect ASN1_TIME_to_tm() availability. Note: ASN1_TIME_to_tm() is not available in LibreSSL yet, mostly because it wasn't on the radar as a public function used by other projects. Hopefully it should become available in the next LibreSSL releases.
jcourreges
added a commit
to jcourreges/ocaml-ssl
that referenced
this pull request
Jan 23, 2022
In savonet/pull/75 detection was implemented with an #ifdef check. However ASN1_TIME_to_tm() was never available as a macro in openssl-1.1.1 releases, so a simple #ifdef check will never succeed. Instead, use dune-configurator to detect ASN1_TIME_to_tm() availability. Note: ASN1_TIME_to_tm() is not available in LibreSSL yet, mostly because it wasn't on the radar as a public function used by other projects. Hopefully it should become available in the next LibreSSL releases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not available on LibreSSL.