Make voxel computation consistent across all source code (#354) #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make voxel computation consistent across all source code, also use std::floor to have explicit control over type casting * Use available function for conversion * Make it a one liner * remove numeric from includes * New proposal * remove numeric from include * shrink diff * Consistency as always --------- Co-authored-by: tizianoGuadagnino <[email protected]> Co-authored-by: Ignacio Vizzo <[email protected]>
|
@tizianoGuadagnino was ist daas? |
* Make voxel computation consistent across all source code, also use std::floor to have explicit control over type casting * Use available function for conversion * Remove redundant Modulus operation for Vocel Hash function, set robin map params instead * Make it a one liner * remove numeric from includes * New proposal * remove numeric from include * shrink diff * Consistency as always * Split changes into two PRs * Revert "Merge remote-tracking branch 'origin' into gupta_fix_hash" This reverts commit 6e46c0d, reversing changes made to 07634eb. --------- Co-authored-by: tizianoGuadagnino <[email protected]> Co-authored-by: Ignacio Vizzo <[email protected]>
* Add a new job just to proof the build is now broken * force 22.04 to make sure it's only a 20.04 problem * Revert "force 22.04 to make sure it's only a 20.04 problem" This reverts commit e1b5e02. * Add cache to ci build * Attempt to fix build in Ubuntu 20.04 * add this comment just to annoy ourselves
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make voxel computation consistent across all source code, also use std::floor to have explicit control over type casting
Use available function for conversion
Make it a one liner
remove numeric from includes
New proposal
remove numeric from include
shrink diff
Consistency as always