Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the space that was in this code block for appium:noReset #3042

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

lee-133
Copy link
Contributor

@lee-133 lee-133 commented Dec 10, 2024

Description

There is a block of code showing an example for appium:noReset. The capability appium:noReset had a space in it:
appium: noReset

If used in a test, the capability would not be passed. Updated it and removed the space.
appium:noReset

Motivation and Context

Fixes a code block so customers can quickly copy/paste the code and it work properly

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation fix (typos, incorrect content, missing content, etc.)

Removed the space that was in this code block for appium:noReset

```js
"appium:noReset" : "true",
"sauce:options" : {
  "cacheId" : "jnc0x1256",
}
```
@lee-133 lee-133 requested a review from a team as a code owner December 10, 2024 21:12
@si-net
Copy link
Collaborator

si-net commented Dec 11, 2024

Hi @diemol, the pipeline failed because @lee-133 createtd the MR from a fork. We should still be save to merge this one right? Just fixes a typo in a markdown.

@lee-snyder133 lee-snyder133 changed the base branch from main to lee-support-updates December 13, 2024 15:38
@si-net si-net merged commit ba2a8ca into saucelabs:lee-support-updates Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants