Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace plexus-archiver with Apache commons-compress #217

Conversation

valfirst
Copy link
Contributor

@valfirst valfirst commented Nov 6, 2023

Reasons:

  • to reduce memory footprint: plexus-archiver is based on Apache commons-compress and includes set of other dependencies
  • plexus-archiver supports wide range of archive formats, but they are not needed, as ci-sauce works only with 2 formats: zip and tar.gz
  • to optimize performance (less I/O operations):
    • tar-file is not created anymore while extracting tar.gz file
    • the archive file is not_downloaded_from_remote-storage/not_extracted_from_jar to the file system, extracting of the archive file is done on the fly

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @valfirst!

@diemol diemol merged commit 2136ba9 into saucelabs:main Nov 10, 2023
@valfirst valfirst deleted the replace-plexus-archiver-with-apache-commons-compress branch November 10, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants