Skip to content

Commit

Permalink
sysctl: Fixed sysctl to work on symlinks(ansible-collections#111)
Browse files Browse the repository at this point in the history
  • Loading branch information
satken2 authored and jillr committed May 7, 2024
1 parent a88f5f8 commit 55ea4ba
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 0 deletions.
3 changes: 3 additions & 0 deletions changelogs/fragments/206_fix_sysctl_to_work_on_symlinks.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
bugfixes:
- sysctl - fix sysctl to work properly on symlinks (https://github.com/ansible-collections/ansible.posix/issues/111).
33 changes: 33 additions & 0 deletions tests/integration/targets/sysctl/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -332,3 +332,36 @@
that:
- sysctl_invalid_set1 is failed
- "'vm.mmap_rnd_bits' not in sysctl_invalid_conf_content.stdout"

# Test sysctl: sysctl_file is symlink
- name: Create link source
copy:
content: |
# Testing Ansible Sysctl module on symlink.
dest: /tmp/ansible_sysctl_test.conf

- name: Create symlink to the conf file
file:
src: /tmp/ansible_sysctl_test.conf
dest: /tmp/ansible_sysctl_test_symlink.conf
state: link

- name: Use sysctl module with symlink sysctl file
sysctl:
name: 'kernel.randomize_va_space'
value: '1'
sysctl_file: /tmp/ansible_sysctl_test_symlink.conf
state: present
sysctl_set: false
reload: false

- Stat sysctl file
stat:
path: /tmp/ansible_sysctl_test_symlink.conf
register: stat_result

- Ensure the sysctl file remains a symlink
assert:
that:
- stat_result.stat.islnk is defined and stat_result.stat.islnk
- stat_result.stat.lnk_source == /tmp/ansible_sysctl_test.conf

0 comments on commit 55ea4ba

Please sign in to comment.