-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix operators in variable names #903
Merged
bgriffith
merged 4 commits into
sasstools:develop
from
DanPurdy:feature/fix-variable-name-format
Oct 26, 2016
Merged
Fix operators in variable names #903
bgriffith
merged 4 commits into
sasstools:develop
from
DanPurdy:feature/fix-variable-name-format
Oct 26, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanPurdy
changed the title
🐛 Fix operators in variable names
Fix operators in variable names
Oct 22, 2016
This appears to be fixed in the |
I don't think it would harm having it though just as a belts and braces for the future? But yeah, I'll try it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you had a variable followed by an operator i.e.
$my-var*1.5
Gonzales would report the variable name as$my-var*1
therefore I've added a small bit of regex to split the string on these occasions which will cover the majority of problems we'd see.fixes #901
<DCO 1.1 Signed-off-by: Dan Purdy [email protected]>