Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix operators in variable names #903

Merged

Conversation

DanPurdy
Copy link
Member

If you had a variable followed by an operator i.e. $my-var*1.5 Gonzales would report the variable name as $my-var*1 therefore I've added a small bit of regex to split the string on these occasions which will cover the majority of problems we'd see.

fixes #901

<DCO 1.1 Signed-off-by: Dan Purdy [email protected]>

@DanPurdy DanPurdy added this to the 1.10 milestone Oct 22, 2016
@DanPurdy DanPurdy changed the title 🐛 Fix operators in variable names Fix operators in variable names Oct 22, 2016
@coveralls
Copy link

coveralls commented Oct 22, 2016

Coverage Status

Coverage remained the same at 97.527% when pulling 36b3b8f on DanPurdy:feature/fix-variable-name-format into a66c707 on sasstools:develop.

@bgriffith
Copy link
Member

bgriffith commented Oct 24, 2016

This appears to be fixed in the v3.4.6 release of Gonzales (tonyganch/gonzales-pe#226 (comment)), so it's likely we don't need this anymore. Could you take out your regex and try the tests?

@DanPurdy
Copy link
Member Author

DanPurdy commented Oct 25, 2016

I don't think it would harm having it though just as a belts and braces for the future? But yeah, I'll try it.

@coveralls
Copy link

coveralls commented Oct 25, 2016

Coverage Status

Coverage remained the same at 97.529% when pulling b82788f on DanPurdy:feature/fix-variable-name-format into 6fd0341 on sasstools:develop.

@coveralls
Copy link

coveralls commented Oct 25, 2016

Coverage Status

Coverage remained the same at 97.529% when pulling b82788f on DanPurdy:feature/fix-variable-name-format into 6fd0341 on sasstools:develop.

@coveralls
Copy link

coveralls commented Oct 26, 2016

Coverage Status

Coverage remained the same at 97.529% when pulling fd8d01b on DanPurdy:feature/fix-variable-name-format into 5b125b6 on sasstools:develop.

@bgriffith bgriffith merged commit d31e7e5 into sasstools:develop Oct 26, 2016
@DanPurdy DanPurdy deleted the feature/fix-variable-name-format branch October 28, 2016 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

variable name format bug
3 participants