Fix issue with shorthand percentage values #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanPurdy
force-pushed
the
feature/fix-shorthand-values
branch
from
b189e19 to
842d33c
Compare
DanPurdy
changed the title
|
closes #435 |
|
Looks good! |
bgriffith
added a commit
that referenced
this pull request
Dec 9, 2015
Fix issue with shorthand percentage values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with the
shorthand-valuesrule as highlighted in #435Also adds a sample of the yml configuration to the docs as I felt the syntax was useful to see examples of for those not too familiar with YAML.
I chose not to bundle this as a hotfix as I don't think there's any point trying to push 1.3.4 out before 1.4.0 is released..
DCO 1.1 Signed-off-by: Dan Purdy [email protected]