Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive for valid css with space-around-operator #395

Merged
merged 4 commits into from
Nov 17, 2015

Conversation

bgriffith
Copy link
Member

This PR fixes a bug where valid css would:
1 - Be flagged up as requiring a space
2 - Cause a error with the parser.

The css in question is negative values for margin, top etc

margin: -15px;

Ps. Thanks to @DanPurdy for catching it!

Closes #394
DCO 1.1 Signed-off-by: Ben Griffith [email protected]

@bgriffith bgriffith added this to the 1.4.0 milestone Nov 12, 2015
@DanPurdy
Copy link
Member

How about variable/selector names, I know they're not targeted but in anticipation of gonzales changes that may affect this it would be good to have them in?

@bgriffith
Copy link
Member Author

I don't feel that's necessary. Since we're only ever targeting ['condition', 'atruleb', 'value', 'atrulerq'] to begin with, selectors should never come up. I know you could potentially future proof it (somehow?!) but I can't see any reason why a character within a selector would ever be classed as an operator.

@DanPurdy
Copy link
Member

'should' 😉

Update this and it's good to go

@DanPurdy
Copy link
Member

grr update again and let me know.

@bgriffith
Copy link
Member Author

I've clicked update. Now it's just waiting game.

DanPurdy added a commit that referenced this pull request Nov 17, 2015
Fix false positive for valid css with space-around-operator
@DanPurdy DanPurdy merged commit 4938c18 into sasstools:develop Nov 17, 2015
@bgriffith bgriffith deleted the fix/space-around-operator branch April 21, 2016 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Space around operator false positive
2 participants