Add coveralls for code coverage #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benthemonkey thanks for this but could we open up issues before starting these types of PR please. Gives everyone a chance to discuss it or give any info on other plans we may have had. I'll leave this one for @Snugug |
|
OK will do next time. |
|
I just looked over the language I used in this PR. I updated it to not be as assuming, given that I didn't ask permission before submitting this PR. 😄 |
benthemonkey
force-pushed
the
feature/coveralls
branch
from
12dddcf to
a863250
Compare
|
We're busy! I'm OK merging this in as long as you update to the latest We can debate the merits of code coverage elsewhere |
benthemonkey
force-pushed
the
feature/coveralls
branch
from
a863250 to
da1d43b
Compare
|
Done. I'm not trying to be pushy. I know you were away doing exciting things. 😄 |
|
👅 |
Snugug
added a commit
that referenced
this pull request
Nov 10, 2015
Add coveralls for code coverage
Snugug
added a commit
to Snugug/sass-lint
that referenced
this pull request
Nov 10, 2015
Resolves sasstools#351 outstanding issue
benthemonkey
pushed a commit
to benthemonkey/sass-lint
that referenced
this pull request
Nov 12, 2015
Resolves sasstools#351 outstanding issue
benthemonkey
pushed a commit
to benthemonkey/sass-lint
that referenced
this pull request
Nov 12, 2015
Resolves sasstools#351 outstanding issue
benthemonkey
pushed a commit
to benthemonkey/sass-lint
that referenced
this pull request
Nov 12, 2015
Resolves sasstools#351 outstanding issue
benthemonkey
pushed a commit
to benthemonkey/sass-lint
that referenced
this pull request
Nov 12, 2015
Resolves sasstools#351 outstanding issue
donabrams
pushed a commit
to donabrams/sass-lint
that referenced
this pull request
Nov 19, 2015
Add coveralls for code coverage
donabrams
pushed a commit
to donabrams/sass-lint
that referenced
this pull request
Nov 19, 2015
Resolves sasstools#351 outstanding issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hooray for promoting test coverage!
I submitted this because I was interested in learning about setting up code coverage tools. Also I wanted to know whether the test cases for my rules are covering every branch of the code.
Feel free to close this PR if there are reasons to not include a code coverage tool. If folks are interested in merging this, then @Snugug (or someone with admin access) will have to set up coveralls.io to track this repo.
Additionally, if this gets merged we should add the coveralls badge to the readme.
DCO 1.1 Signed-off-by: Ben Rothman [email protected]