Add Sass tests for rules & fix related issues #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $invalid-mixed-letters-med: #abc4 | ||
| $invalid-mixed-letters-short: #a1 | ||
|
|
||
| $invalid-character-map: (invalid-characters-upper-letters: #GHIJKL, invalid-characters-upper-letters-short: #GHI, even-more-invalid-map: ( invalid-characters-lower-letters-short: #ghijkl, invalid-characters-lower-letters-short: #ghi )) |
There was a problem hiding this comment.
Are you forced to write a map on a single line in Sass?
There was a problem hiding this comment.
Yeah... it's....different...
| @@ -17,3 +17,21 @@ describe('indentation', function () { | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
|
|
|||
| ////////////////////////////// | |||
There was a problem hiding this comment.
Lets not forget about these in 1.4.0 😄
|
Great stuff. This should make sass-lint even more bullet proof moving forward, although this hides the fact that you've actually fixed a lot of these rules in hotfixes already so thanks for those! My only other comment is maybe to add a few more comments as in the |
|
This |
|
Awesome! |
DanPurdy
added a commit
that referenced
this pull request
Oct 8, 2015
Add Sass tests for rules & fix related issues
donabrams
pushed a commit
to donabrams/sass-lint
that referenced
this pull request
Nov 19, 2015
Add Sass tests for rules & fix related issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the size of this PR.
It adds Sass tests for the majority of the rules listed here #166. The only one missing is indentation as this needs a rewrite.
It also includes a fix for the
empty-line-between-blockrule as this required helpers bundled with the soon to be released version 1.3 on develop which will close #216 and close #228DCO 1.1 Signed-off-by: Ben Griffith [email protected]