Fix Sass syntax issue with empty-line-between-block rule

lib/rules/empty-line-between-blocks.js

@@ -1,36 +1,97 @@
 'use strict';
 
-var helpers = require('../helpers'),
-    os = require('os');
+var helpers = require('../helpers');
+
+var counter,
+    syntax;
 
 var findNearestReturn = function (parent, i) {
   var previous,
       doublePrevious,
       space;
 
-  if (i >= 2) {
-    doublePrevious = parent.content[i - 2];
+  if (syntax === 'scss') {
+    if (i >= 2) {
+      doublePrevious = parent.content[i - 2];
 
-    if (doublePrevious.type.indexOf('Comment') !== -1) {
-      return findNearestReturn(parent, i - 1);
+      if (doublePrevious.type.indexOf('Comment') !== -1) {
+        return findNearestReturn(parent, i - 1);
+      }
     }
-  }
 
-  if (i >= 1) {
-    previous = parent.content[i - 1];
+    if (i >= 1) {
+      previous = parent.content[i - 1];
+
+      if (previous.type.indexOf('Comment') !== -1) {
+        return findNearestReturn(parent, i - 1);
+      }
 
-    if (previous.type.indexOf('Comment') !== -1) {
-      return findNearestReturn(parent, i - 1);
+      // If first item in block, ignore
+      if (i - 1 === 0) {
+        return false;
+      }
+
+      if (previous.type === 'space') {
+        space = helpers.isEmptyLine(previous.content);
+
+        return {
+          'space': space,
+          'previous': previous
+        };
+      }
     }
+  }
+  else if (syntax === 'sass') {
+
+    if (parent.content[i - 1]) {
+      previous = parent.content[i - 1];
 
-    if (previous.type === 'space') {
-      space = previous.content.indexOf(os.EOL + '' + os.EOL) >= 0;
+      if (counter === 2) {
+        return {
+          space: true,
+          previous: previous
+        };
+      }
+
+      if (previous.is('space') || previous.is('declarationDelimiter')) {
+        if (helpers.hasEOL(previous.content)) {
+          counter++;
+        }
 
-      return {
-        'space': space,
-        'previous': previous
-      };
+        return findNearestReturn(parent, i - 1);
+      }
+
+      // If ruleset, we must reset the parent to be the previous node and
+      // loop through that
+      else if (previous.is('ruleset') || previous.is('include')) {
+        var previousNode = previous.content[previous.content.length - 1];
+
+        // Set the i parameter for findNearestReturn to be the length of the
+        // content array in order to get the last one
+        return findNearestReturn(previousNode, previousNode.content.length);
+      }
+      else {
+        counter = 0;
+
+        if (previous.type.indexOf('Comment') !== -1) {
+
+          // If it's the first line
+          if (previous.start.line === 1) {
+            return {
+              space: true,
+              previous: previous
+            };
+          }
+
+          return findNearestReturn(parent, i - 1);
+        }
+      }
     }
+
+    return {
+      space: false,
+      previous: previous
+    };
   }
 };
 
@@ -42,30 +103,90 @@ module.exports = {
   'detect': function (ast, parser) {
     var result = [];
 
-    ast.traverseByType(['ruleset'], function (ruleset, i, parent) {
+    // Set syntax
+    syntax = ast.syntax;
+
+    ast.traverseByType('ruleset', function (node, j, p) {
       var space;
 
-      space = findNearestReturn(parent, i);
+      if (syntax === 'scss') {
+        space = findNearestReturn(p, j);
 
-      if (space) {
-        if (parser.options.include && !space.space && i !== 1) {
-          result = helpers.addUnique(result, {
-            'ruleId': parser.rule.name,
-            'line': space.previous.end.line,
-            'column': space.previous.end.column,
-            'message': 'Space expected between blocks',
-            'severity': parser.severity
-          });
+        if (space) {
+          if (parser.options.include && !space.space && j !== 1) {
+            result = helpers.addUnique(result, {
+              'ruleId': parser.rule.name,
+              'line': space.previous.end.line,
+              'column': 1,
+              'message': 'Space expected between blocks',
+              'severity': parser.severity
+            });
+          }
+          else if (!parser.options.include && space.space) {
+            result = helpers.addUnique(result, {
+              'ruleId': parser.rule.name,
+              'line': space.previous.end.line,
+              'column': 1,
+              'message': 'Space not allowed between blocks',
+              'severity': parser.severity
+            });
+          }
         }
-        else if (!parser.options.include && space.space) {
-          result = helpers.addUnique(result, {
-            'ruleId': parser.rule.name,
-            'line': space.previous.end.line,
-            'column': space.previous.end.column,
-            'message': 'Space not allowed between blocks',
-            'severity': parser.severity
+      }
+      else if (syntax === 'sass') {
+        // Reset the counter for each ruleset
+        counter = 0;
+
+        if (node.is('ruleset')) {
+
+          node.forEach('block', function (block, i, parent) {
+            var previous;
+
+            // If we can go up one, reassign the 'previous node'
+            if (parent.content[i - 1]) {
+              previous = parent.content[i - 1];
+            }
+            else {
+              // If we can't, go back current to previous
+              previous = block;
+            }
+
+            // If it's a new line, lets go back up to the selector
+            if (previous.is('space') && helpers.hasEOL(previous.content)) {
+
+              // If we have a node (most likely type of selector)
+              if (parent.content[i - 2]) {
+
+                if (typeof parent.content[i - 3] === 'undefined') {
+                  space = findNearestReturn(p, j);
+                }
+              }
+            }
           });
         }
+
+        if (space && space.previous) {
+          if (space.previous.start.line !== 1) {
+            if (parser.options.include && !space.space) {
+              result = helpers.addUnique(result, {
+                'ruleId': parser.rule.name,
+                'line': space.previous.end.line + 1,
+                'column': 1,
+                'message': 'Space expected between blocks',
+                'severity': parser.severity
+              });
+            }
+            else if (!parser.options.include && space.space) {
+              result = helpers.addUnique(result, {
+                'ruleId': parser.rule.name,
+                'line': space.previous.end.line + 1,
+                'column': 1,
+                'message': 'Space not allowed between blocks',
+                'severity': parser.severity
+              });
+            }
+          }
+        }
       }
     });