Hotfix master - Fix Sass syntax issue with clean-import-paths rule #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 21, 2015
| @@ -149,4 +149,8 @@ helpers.loadConfigFile = function (configPath) { | |||
| return file; | |||
| }; | |||
|
|
|||
| helpers.stripQuotes = function (str) { | |||
There was a problem hiding this comment.
Are there tests for this coming on the develop branch?
|
Seems good, just the extra helper function tests missing.. |
|
Tests added for helper function 🚀 |
|
👍 |
DanPurdy
added a commit
that referenced
this pull request
Sep 24, 2015
…aths Hotfix master - Fix Sass syntax issue with clean-import-paths rule
donabrams
pushed a commit
to donabrams/sass-lint
that referenced
this pull request
Nov 19, 2015
…-import-paths Hotfix master - Fix Sass syntax issue with clean-import-paths rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clean-import-paths doesn't work with Sass syntax. This fixes that issue.
Fixes #179
DCO 1.1 Signed-off-by: Ben Griffith [email protected]