New rule: space around operator

[skovhus]

This resolves #31.

Due to bugs in gonzales-pe the following will currently fail:

body {
  background: url('a'  +  'b.png');  // will not throw an error
}

$foo: 90px   %10px;  // will crash

DCO 1.1 Signed-off-by: Kenneth Skovhus [email protected]

[bgriffith]

Should be space-around-operator

[skovhus]

@bgriffith Good catch. Should be fixed now.

[DanPurdy]

Hey @skovhus thanks for this, we'll leave it on review until 1.2.0 is out. I believe we are planning to move to using a develop branch post 1.2 to enable us to simultaneously release hot fixes to master if necessary while continuing to develop and merge rules and features.

As you pointed out too we're awaiting a new release of gonzales-pe to fix some of the issues we've encountered.

[skovhus]

@DanPurdy makes sense. Looking forward to 1.2.0. After that https://github.com/skovhus/SublimeLinter-contrib-sass-lint should be ready for use. : )

Out of curiosity, what were the considerations in choosing gonzales-pe? I haven't looked in to this, but I for me it would make sense to use the same parser/AST as node-sass. That should be pretty battle tested by now.

[DanPurdy]

Yeah it's gonna be good to get 1.2.0 out, and a sublime linter plugin ready to go is also great news! 👍

I've only come on board recently as I'm looking forward to moving away from the ruby dependencies in some of our projects. @Snugug has talked about it in a few of the earlier issues though., but he will be able to tell you why exactly.

[Snugug]

Gonzales was chosen because Libsass (the compiler that Node Sass uses) doesn't provide its AST publicly and, in its current state, wouldn't be useable enough for linting.

There is an issue in Libsass to expose the AST, but until that lands (and the AST is robust enough to support writing a linter against), we can't use it for Sass Lint.

[skovhus]

@Snugug Thanks for clarifying.

Another thing now that we are talking about the background of this project: what are your vision in terms of rules porting? Do you imagine sass-lint to port all scss-lint rules and their many options?

[Snugug]

If you want to discuss this, please open an issue to discuss roadmap

On Sep 6, 2015, at 4:22 PM, Kenneth Skovhus [email protected] wrote:

@Snugug Thanks for clarifying.

Another thing now that we are talking about the background of this project: what are your vision in terms of rules porting? Do you imagine sass-lint to port all scss-lint rules and their many options?

—
Reply to this email directly or view it on GitHub.

[Snugug]

This will need to be re-rolled off of the develop branch

[DanPurdy]

Hey @skovhus this is ready for a new PR to be created in to develop if you have the time.

Thanks!

[DanPurdy]

I'm going to close this for now. I've just run through it to update with sass tests and even a few of the scss tests aren't doing what they are supposed to. Will definitely need more work.