Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule: Color Keyword #102

Merged
merged 7 commits into from
Sep 5, 2015
Merged

Conversation

DanPurdy
Copy link
Member

@DanPurdy DanPurdy commented Sep 4, 2015

Rule color-keyword enforces the use of hexadecimal colour values instead of CSS colour literals.

A warning message will display to tell you which colour literal needs replacing and it will also display the correct hexadecimal value.

Color 'red' should be written in its hexadecimal form #ff0000

closes #101

DCO 1.1 Signed-off-by: Dan Purdy [email protected]

@DanPurdy DanPurdy added this to the 1.2.0 milestone Sep 4, 2015
@bgriffith
Copy link
Member

Need to add rebeccapurple literal + hex to literals.yml

@DanPurdy
Copy link
Member Author

DanPurdy commented Sep 5, 2015

Any others? I scoured around for a definitive list..

@bgriffith
Copy link
Member

Only spotted that one! Though I don't know them all off by heart. The list is probably good, rebeccapurple is a pretty new one while the others haven't changed for a long time so that's probably the reason why.

@DanPurdy
Copy link
Member Author

DanPurdy commented Sep 5, 2015

Sorted, I think it is the only one missing I double checked all the usual resources..

easier to check without the whitespace changes..
DanPurdy@871a055?w=1

@bgriffith
Copy link
Member

Looking good! :shipit:

bgriffith added a commit that referenced this pull request Sep 5, 2015
@bgriffith bgriffith merged commit 2001711 into sasstools:master Sep 5, 2015
@DanPurdy DanPurdy mentioned this pull request Sep 5, 2015
@DanPurdy DanPurdy deleted the feature/color-keyword branch September 7, 2015 22:39
donabrams pushed a commit to donabrams/sass-lint that referenced this pull request Nov 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants