chore: store built vsix #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scnwwu
force-pushed
the
p-scnwwu-storevsix
branch
2 times, most recently
from
bf558bf to
5b5fe27
Compare
scottdover
reviewed
Oct 23, 2023
.github/workflows/main.yml
Outdated
| @@ -27,3 +26,18 @@ jobs: | |||
| echo $CHANGES | |||
| exit 1 | |||
| fi | |||
|
|
|||
| build: | |||
There was a problem hiding this comment.
Translation check was setup for workflow_dispatch where you can manually trigger a run of it in github actions as needed. Do we think adding this here will cause any issues with that?
There was a problem hiding this comment.
Thanks for pointing it out. I separated them.
scnwwu
force-pushed
the
p-scnwwu-storevsix
branch
from
5b5fe27 to
e8b2b15
Compare
scottdover
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Store the built vsix file as artifact so that anyone can download and directly play with PR or latest main branch without build effort.
Testing
See artifact for this build https://github.com/sassoftware/vscode-sas-extension/actions/runs/6571171460