Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve translation check #495

Merged
merged 6 commits into from
Sep 8, 2023
Merged

Conversation

scottdover
Copy link
Contributor

@scottdover scottdover commented Sep 7, 2023

Summary
This makes a few change to how we check for translations:

  • It splits this into a distinct workflow that is ran on a push to main (instead of checking for every pull request action)
  • It also adds a workflow_dispatch trigger such that we can manually run this check with any branch
  • It updates the output to only list the files that need to be updated for translations. See the two examples below

Example with no translations needed:
Screenshot 2023-09-07 at 9 08 29 AM

Example with translations needed:
Screenshot 2023-09-07 at 9 08 09 AM

Testing

  • Made sure github actions passed
  • Temporarily added this branch to the translation check
  • Will test workflow_dispatch on main (workflow_dispatch triggers have to be in the default branch before they can be triggered via actions)

@scottdover scottdover marked this pull request as ready for review September 7, 2023 13:12
Copy link
Member

@scnwwu scnwwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@scottdover scottdover merged commit 5caa488 into main Sep 8, 2023
@scottdover scottdover deleted the feat/improve-translation-check branch September 8, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants