fix: improve the new file/folder name validator (#156) #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scnwwu
approved these changes
Mar 13, 2023
scottdover
reviewed
Mar 13, 2023
scottdover
approved these changes
Mar 15, 2023
Zhirong2022
added
testing-complete
Zhirong2022
approved these changes
Mar 23, 2023
Zhirong2022
added
verified
and removed
testing-complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #156
I noticed that the folder service does not check the special characters so I changed the folder name validator to only check the max length. If the name is more than 100 characters, there would be a new error message.
And change the validator for the new file name to allow Chinese characters (as well as other languages)
Testing
Test case in #156