-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: (PSKD-904) Support credentials when assuming an IAM role #319
Conversation
Signed-off-by: David.Houck <[email protected]>
Signed-off-by: David.Houck <[email protected]>
Signed-off-by: David.Houck <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some edits!
Signed-off-by: David.Houck <[email protected]>
Hi @supear, please review the latest commit for updates based on your suggested doc changes, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one typo. I think it's good to go once that's fixed!
This line from fsx_ontap will need to be adapted for the iam role scenario:
Otherwise it fails like this:
|
Signed-off-by: David.Houck <[email protected]>
… comment Signed-off-by: David.Houck <[email protected]>
Hi @supear, based on your last comment and the new commit, I will go ahead and resolve your doc review comments as completed, sound good? |
Signed-off-by: David.Houck <[email protected]>
Hi @ajeffowens , the latest commit should handle creating the correct policy attachment whether using an assumed IAM role or IAM user. I'll message you once I have a new image ready that I'm hoping you can try out again. |
Signed-off-by: David.Houck <[email protected]>
…cation Signed-off-by: David.Houck <[email protected]>
Signed-off-by: David.Houck <[email protected]>
Signed-off-by: David.Houck <[email protected]>
Changes
authentication_mode
as a General configuration variableadmin_access_entry_role_arns
as a General configuration variable. Add behavior to create an admin level EKS access entry for each role ARN specified in this list of strings.