Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (IAC-658): Updating default value for V4MT_TENANT_CAS_CUSTOMIZATION #281

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

riragh
Copy link
Member

@riragh riragh commented Aug 11, 2022

Originally the default value for V4MT_TENANT_CAS_CUSTOMIZATION was set as null. However, ansible treats 'null' as a valid value for dictionary being defined and tries to run dictionary operations.

Change:

Updated the default value for V4MT_TENANT_CAS_CUSTOMIZATION as a empty dictionary.

Tests:

This specific issue was hit when V4MT_TENANT_CAS_CUSTOMIZATION wasn't provided and ansible used the null value as default.

  • Verified with the default changed, the issue was not seen.
  • Ran other combinations with V4MT_TENANT_CAS_CUSTOMIZATION only defined for two out three tenants
  • Also verified when V4MT_TENANT_CAS_CUSTOMIZATION is defined with only tenant names but no customizations.

@riragh riragh added the bug Something isn't working label Aug 11, 2022
@riragh riragh self-assigned this Aug 11, 2022
Copy link
Member

@dhoucgitter dhoucgitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the clarification

@riragh riragh merged commit 1fecd2a into staging Aug 11, 2022
@riragh riragh deleted the tenant_cas branch August 16, 2022 17:34
@riragh riragh mentioned this pull request Aug 16, 2022
@riragh riragh changed the title (IAC-658): fix: Updating default value for V4MT_TENANT_CAS_CUSTOMIZATION fix: (IAC-658): Updating default value for V4MT_TENANT_CAS_CUSTOMIZATION Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants