Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: (IAC-658): Support CAS customizations for tenants #278

Merged
merged 4 commits into from
Aug 10, 2022
Merged

feat: (IAC-658): Support CAS customizations for tenants #278

merged 4 commits into from
Aug 10, 2022

Conversation

riragh
Copy link
Member

@riragh riragh commented Aug 9, 2022

Changes:

  • Updated the CAS transformer templates on provider side to be restricted to default CAS server
  • Added a new map of object variable V4MT_TENANT_CAS_CUSTOMIZATION to accept CAS customization for the tenants
    See the new structure in CONFIG-VARS.md file

Tests

  • Verified provider deployment successful with updated CAS transformers.
  • Verified different combinations of the tenant CAS customizations by setting V4MT_TENANT_CAS_CUSTOMIZATION.
  • Verified tenant CAS server directories are created with default setting if customizations are not provided.

@riragh riragh added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 9, 2022
@riragh riragh self-assigned this Aug 9, 2022
thpang
thpang requested changes Aug 9, 2022
View reviewed changes
Copy link
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial comments and changes

@riragh riragh marked this pull request as draft August 9, 2022 21:24
@riragh riragh marked this pull request as ready for review August 9, 2022 22:07
thpang
thpang reviewed Aug 10, 2022
View reviewed changes
thpang
thpang requested changes Aug 10, 2022
View reviewed changes
Copy link
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a couple of updates requested. Also what's the focus on the store for each tenant? Is there any guidance setup that the CAS documentation clarifies? Not seeing any information here on that.

thpang
thpang approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the updates

dhoucgitter
dhoucgitter reviewed Aug 10, 2022
View reviewed changes
Copy link
Member

@dhoucgitter dhoucgitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, content in tenant-cas-customizations.yaml was interesting

dhoucgitter
dhoucgitter approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@dhoucgitter dhoucgitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meant to click on approve b4

@riragh riragh merged commit 1ab22d9 into staging Aug 10, 2022
@riragh riragh deleted the cas_updates branch August 10, 2022 18:09
@riragh riragh mentioned this pull request Aug 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhoucgitter dhoucgitter dhoucgitter approved these changes

@thpang thpang thpang approved these changes

@sayeun sayeun Awaiting requested review from sayeun

@jarpat jarpat Awaiting requested review from jarpat

Assignees

@riragh riragh

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@riragh @dhoucgitter @thpang