feat: (IAC-629) Support SingleStore (DAC) #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhoucgitter
added
documentation
thpang
reviewed
Aug 9, 2022
…(pre) Why: The tranformers present in existing TLS components need to come after any user customization components so that their transformers have user component content to operate on. Populate user contributed components section in kustomization.yaml as needed even if no components are present in ordered_overlays dictionary. This scenario is true for a SingleStore deployment where TLS is disabled.
dhoucgitter
commented
Aug 12, 2022
| @@ -25,4 +25,12 @@ namespace: {{ NAMESPACE }} | |||
| {% endif %} | |||
|
|
|||
| {% endfor %} | |||
|
|
|||
| {% if "components" not in ordered_overlays.result %} | |||
There was a problem hiding this comment.
Lines 29-36 added to the kustomization.yaml template handle the scenario when DAC does not contribute any hard-coded component entries into ordered_overlays (as when TLS is disabled) and then skips over adding user submitted components under site-config such as SingleStore.
jarpat
reviewed
Aug 16, 2022
Co-authored-by: Jay Patel <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SingleStore README and siteconfig_info change