Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (IAC-454) Increasing retries for onboard/offboard jobs #266

Merged
merged 4 commits into from
Jul 28, 2022
Merged

fix: (IAC-454) Increasing retries for onboard/offboard jobs #266

merged 4 commits into from
Jul 28, 2022

Conversation

riragh
Copy link
Member

@riragh riragh commented Jul 27, 2022 •
edited
Loading

Change:

  1. To avoid timing errors increasing delays and retries for onboard/offboard jobs. Add default variables to specify the retry and delay time
  2. Doc update: rearranged the offboarding and uninstall to be after 'Log In and Validate an Onboarded Tenant' section and added more info to offboard section
  3. Offboarding is a required step before uninstall. Made changes to reflect so. Only removing the cas directories like previously doesn't clean up after database resources that get created during onboarding.
  4. Added guard rail in playbook to run multi-tenancy tasks only if it is enabled

Tests:

  • On multi-tenant deployment now errors found on onboarding and offboarding process.
  • Verified the changes on schema mode deployment, database mode deployment and TLS disabled
  • Also verified on a large order (Order contains all products supporting multi-tenancy), no issues found on onboarding/offboarding single tenant and multiple tenants.

@riragh riragh marked this pull request as draft July 27, 2022 23:31
@riragh riragh marked this pull request as ready for review July 27, 2022 23:34
@riragh riragh requested review from dhoucgitter, jarpat and sayeun July 27, 2022 23:35
thpang
thpang requested changes Jul 28, 2022
View reviewed changes
Copy link
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one small change needed. Otherwise great work.

roles/multi-tenancy/defaults/main.yml Outdated
@@ -18,3 +18,9 @@ V4MT_PROVIDER_PASSWORD: null

V4MT_CAS_WORKER_COUNT: 0
V4MT_CAS_BACKUP: 0

# Setting values for retry and delay
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just clarify that these values are in seconds

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in the latest change.

thpang
thpang approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dhoucgitter
dhoucgitter approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@dhoucgitter dhoucgitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@riragh riragh merged commit a9fa863 into staging Jul 28, 2022
@riragh riragh deleted the mt_updates branch July 28, 2022 15:11
@riragh riragh added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 28, 2022
@riragh riragh mentioned this pull request Aug 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhoucgitter dhoucgitter dhoucgitter approved these changes

@thpang thpang thpang approved these changes

@jarpat jarpat Awaiting requested review from jarpat

@sayeun sayeun Awaiting requested review from sayeun

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@riragh @dhoucgitter @thpang