-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: (IAC-480) Change default certificate generator to openssl #245
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a general comment here. There is no parity between what used to be in place for the cert-manager and openssl that was installed during the deployment repo install phase. Would be nice, if possible to have openssl as part of the baseline to keep things aligned.
I think this is ready for re-review after the discussion we had last week. |
docs/CONFIG-VARS.md
Outdated
@@ -279,7 +279,7 @@ V4_CFG_POSTGRES_SERVERS: | |||
|
|||
| Name | Description | Type | Default | Required | Notes | Tasks | | |||
| :--- | ---: | ---: | ---: | ---: | ---: | ---: | | |||
| CERT_MANAGER_ENABLED | Whether to deploy tool | bool | true | false | | baseline | | |||
| CERT_MANAGER_ENABLED | Whether to deploy tool | bool | false | false | | baseline | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a doc comment.
Since there are now two certificate handling objects that IAC can impact, I think it might help to say, "Whether to deploy certificate-manager into the cluster" to be more specific than "tool" here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhoucgitter, you're right that description doesn't seem to be clear. I've updated the description and notes section to:
Name | Description | Type | Default | Required | Notes | Tasks |
---|---|---|---|---|---|---|
CERT_MANAGER_ENABLED | Whether to deploy cert-manager into the cluster using helm | bool | false | false | Required if V4_CFG_TLS_GENERATOR is set to cert-manager and it's not already installed |
baseline |
Let me know if that sounds better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a minor doc comment, otherwise lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We'll have future conversations about OpenSSL and possible cluster enablement vs namespace enablement with Viya.
Changes
Makes the new default for
V4_CFG_TLS_GENERATOR
to openssl. Also changesCERT_MANAGER_ENABLED
to false so cert-manager does not get installed during the baseline by default.Tests
See internal IAC-480 ticket