(IAC-553) move to kubectl 1.22.10 to support k8s 1.23 #236
Conversation
dhoucgitter
added
documentation
Dockerfile
Outdated
| @@ -45,8 +47,7 @@ ENV HOME=/viya4-deployment | |||
| RUN pip install -r ./requirements.txt \ | |||
| && ansible-galaxy install -r ./requirements.yaml \ | |||
| && chmod -R g=u /etc/passwd /etc/group /viya4-deployment/ \ | |||
| && chmod 755 /viya4-deployment/docker-entrypoint.sh \ | |||
| && git config --system --add safe.directory /viya4-deployment | |||
There was a problem hiding this comment.
Why was this removed? If someone clones this repo it'll have a value.
There was a problem hiding this comment.
I removed line 49 since for this Dockerfile the /viya4-deployment folder is not a git managed folder and when I ran "docker build" with that line in place, I got a git error indicating that. Removing the line allowed me to build the container.
There was a problem hiding this comment.
@thpang, I restored the deleted line after our discussion, ready for re-review
|
I've made similar comments elsewhere, but saying that "Viya will support K8s 1.21, 1.22 and 1.23 in June 2022" isn't quite accurate. Those versions will be supported at fast/2020, but lts/2022.1, which just came out in May 2022, only supports 1.20-1.22. Another LTS won't be released until November or thereabouts. So if kubectl is bumped to 1.22, this project would be using an unsupported kubectl version for LTS deployments into K8S 1.20. That being said, I'm not saying this update shouldn't occur, and perhaps I'm being nitpicky. But it's something to keep in mind. |
Changes
Because Viya will support K8s 1.21, 1.22 and 1.23 in June 2022, the version of kubectl needs to be bumped up to 1.22 so that it will be in the required -1/+1 range for supported versions of K8s.
Tests