Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(IAC-562) Update Kustomize Doc #233

Merged
merged 2 commits into from
Jun 8, 2022
Merged

(IAC-562) Update Kustomize Doc #233

merged 2 commits into from
Jun 8, 2022

Conversation

jarpat
Copy link
Contributor

@jarpat jarpat commented Jun 3, 2022 •
edited
Loading

Changes

Updates the "SAS Viya Customizations" section in the readme.

resolves #229

@jarpat jarpat added the documentation Improvements or additions to documentation label Jun 3, 2022
@jarpat jarpat changed the title Update Kustomize Doc (IAC-562) Update Kustomize Doc Jun 3, 2022
dhoucgitter
dhoucgitter reviewed Jun 3, 2022
View reviewed changes
@jarpat @dhoucgitter
Update README.md
724ac93 
grammar

Co-authored-by: David Houck <[email protected]>
@dhoucgitter dhoucgitter self-requested a review June 6, 2022 17:23
dhoucgitter
dhoucgitter approved these changes Jun 6, 2022
View reviewed changes
Copy link
Member

@dhoucgitter dhoucgitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jarpat jarpat requested review from sayeun and thpang June 7, 2022 22:03
thpang
thpang approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jarpat jarpat merged commit 5faa962 into staging Jun 8, 2022
@jarpat jarpat deleted the kustomize_doc branch June 8, 2022 17:24
@dhoucgitter dhoucgitter mentioned this pull request Jun 17, 2022
Merged
@jarpat jarpat linked an issue Jul 5, 2022 that may be closed by this pull request
Can't use customer-provided-merge-sas-certframe-configmap.yaml #229
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhoucgitter dhoucgitter dhoucgitter approved these changes

@thpang thpang thpang approved these changes

@sayeun sayeun Awaiting requested review from sayeun

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't use customer-provided-merge-sas-certframe-configmap.yaml
3 participants
@jarpat @dhoucgitter @thpang