Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(IAC-528) Added git share #216

Merged
merged 2 commits into from
Apr 25, 2022
Merged

(IAC-528) Added git share #216

merged 2 commits into from
Apr 25, 2022

Conversation

thpang
Copy link
Member

@thpang thpang commented Apr 24, 2022

@thpang thpang added the bug Something isn't working label Apr 24, 2022
@riragh riragh changed the title Added git share (IAC-528) Added git share Apr 25, 2022
riragh
riragh approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@riragh riragh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the new change looks good. See the test results in IAC-528.

sayeun
sayeun approved these changes Apr 25, 2022
View reviewed changes
Copy link

@sayeun sayeun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good based on the test result.

@jarpat jarpat merged commit 171bceb into staging Apr 25, 2022
@jarpat jarpat deleted the git_share_fix branch April 25, 2022 14:26
@riragh riragh mentioned this pull request Apr 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayeun sayeun sayeun approved these changes

@riragh riragh riragh approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thpang @sayeun @riragh @jarpat