Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(IAC-483) Conditionally Patch ingress-nginx Config #202

Merged
merged 2 commits into from
Apr 4, 2022

Conversation

jarpat
Copy link
Contributor

@jarpat jarpat commented Mar 28, 2022

Changes

The mitigation will be applied by default for K8s clusters whose version is >=1.22.x
and whose ingress-ngnix version is >=1.1.0 or (>=0.50.0 and <1.0.0, for the updated legacy versions of nginx that support this CVE).

Tests

Performed deployments in AKS on both 1.22.6 & 1.21.9 clusters to see the CVE mitigation patch behavior. All deployments in this table resulted in a healthy Viya deployment.

Cadence K8s Version Ingress-Nginx Version Was CVE Mitigation Applied by Default
2021.2.5 1.22.6 1.1.0 Yes
2021.2.4 1.22.6 1.1.0 Yes
2021.2.5 1.22.6 1.1.1 (Custom INGRESS_NGINX_CHART_VERSION) Yes
Fast R/S 1.22.6 1.1.0 Yes
2021.2.4 1.21.9 0.50.0 No
2021.2.2 1.21.9 0.50.0 No
2021.2 1.21.9 0.50.0 No

@jarpat jarpat added the enhancement New feature or request label Mar 28, 2022
@jarpat jarpat self-assigned this Mar 28, 2022
@jarpat jarpat requested a review from thpang March 28, 2022 17:50
Copy link
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jarpat jarpat merged commit cb4c374 into staging Apr 4, 2022
@jarpat jarpat deleted the ingress_nginx_patch branch April 4, 2022 20:04
@jarpat jarpat mentioned this pull request Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants