Bookmarks features and changes for issue #40 #42
Conversation
|
Test comment 22. Nov. |
| @@ -484,14 +486,33 @@ | |||
| </xsl:variable> | |||
| <xsl:variable name="stpURI"><xsl:text>/SASStoredProcess/do?_action=form,properties,execute&_program=</xsl:text><xsl:value-of select="$stpProgram"/></xsl:variable> | |||
|
|
|||
| <a><xsl:attribute name="href"><xsl:value-of select="$stpURI"/></xsl:attribute><xsl:value-of select="@Name"/></a> | |||
| <xsl:variable name="stpLocation"> | |||
There was a problem hiding this comment.
calculating this path is an expensive operation, so we should try to do it as few times as possible.
I would recommend moving this variable stpLocation setting up, before the setting of stpProgram, and then change the setting of stpProgram to be
<xsl:value-of select="$stpLocation"/>xsl:text/</xsl:text><xsl:value-of select="@name"/>
so as to not have to calculate the path twice
There was a problem hiding this comment.
I'm going to do the adjustment as you have suggested.
| <a><xsl:attribute name="href"><xsl:value-of select="$wrsURI"/></xsl:attribute><xsl:value-of select="@Name"/></a> | ||
| <a><xsl:attribute name="href"><xsl:value-of select="$wrsURI"/></xsl:attribute><xsl:value-of select="@Name"/></a><br/> | ||
|
|
||
| <xsl:variable name="stpLocation"> |
There was a problem hiding this comment.
chose a variable name here consistent with the others in this template, ex. wrsLocation, instead of the one copied from stp.
There was a problem hiding this comment.
I'm going to do the adjustment as you have suggested.
| @@ -874,6 +874,7 @@ | |||
| { | |||
| selBox = document.getElementById(name); | |||
| selectAllOptions(selBox); | |||
| window.location.href = sasPortalAppHome; | |||
There was a problem hiding this comment.
What exactly is this code doing? Why are we setting the window href here? That will force a redirect, correct?
There was a problem hiding this comment.
If we add a new item to the element and press OK, the new item won't appear in the portal. So this line forces a reload of the page. To do this we need the Java script variable "var sasPortalAppHome="/SASPortalApp";". Alternatively, we can store the URL in the session stoarage and then use it from there.
web/setup.js.template
Outdated
| /* | ||
| * Allow overrides of default Portal URL pathname | ||
| */ | ||
| var sasPortalAppHome="/SASPortalApp"; |
There was a problem hiding this comment.
Why is this needed?
There was a problem hiding this comment.
This file looks like an exact copy of the update.collections.xslt file. If that is so, then we should rework the collections and bookmark update to both call a shared file.
When creating the shared file, you have to be careful with the paths to load localizations, etc. I don't see that the file has any localizations, but if it needs it, you can see an example of how this works, see the remove.xxx.xslt files and how they reference the shared remove.psportlet.xslt file (and how that shared file accesses the localizations).
There was a problem hiding this comment.
I'm going to do the adjustment as you have suggested.
…ks portlet. sassoftware#2 Signed-off-by: Said J. <[email protected]>
Signed-off-by: Said J. <[email protected]>
Signed-off-by: Said J. <[email protected]>
Signed-off-by: Said J. <[email protected]>
Signed-off-by: Said J. <[email protected]>
… collections Signed-off-by: Said J. <[email protected]>
Signed-off-by: Said J. <[email protected]>
Signed-off-by: Said J. <[email protected]>
Signed-off-by: Said J. <[email protected]>
Resolving issue #2, #39 and #40