Document first-class mixins #852

nex3 · 2023-09-28T19:46:05Z

Closes #786

See sass/dart-sass#2073

Closes #786

nex3 · 2023-09-28T19:46:28Z

cc @connorskees

source/documentation/values/mixins.md

This is necessary to ensure that it has access to the linked version of the Dart Sass repository.

source/documentation/modules/meta.md

Goodwine · 2023-09-28T21:46:03Z

source/documentation/modules/meta.md

+
+  [mixin value]: /documentation/values/mixins
+
+  If `$module` is `null`, this returns the mixin named `$name` defined in the


I take it that meta.get-mixin(my-module.my-mixin) won't return anything because it should have been written as meta.get-mixin(my-module, my-mixin), is that right?

I think it might be helpful to call that out, but I realize get-function doesn't, so maybe that's OK.

Let's wait and see if users actually make that mistake before we add extra text for it. I don't think I've seen anyone do that with meta.get-function().

source/documentation/values/mixins.md

Goodwine

looks good except for that one broken link

source/documentation/values/mixins.md

Closes #786

* Bump postcss from 8.4.27 to 8.4.31 Bumps [postcss](https://github.com/postcss/postcss) from 8.4.27 to 8.4.31. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.4.27...8.4.31) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * Document first-class mixins (#852) Closes #786 * Bump @types/seedrandom from 3.0.5 to 3.0.6 (#854) Bumps [@types/seedrandom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/seedrandom) from 3.0.5 to 3.0.6. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/seedrandom) --- updated-dependencies: - dependency-name: "@types/seedrandom" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump immutable from 4.3.1 to 4.3.4 (#858) Bumps [immutable](https://github.com/immutable-js/immutable-js) from 4.3.1 to 4.3.4. - [Release notes](https://github.com/immutable-js/immutable-js/releases) - [Changelog](https://github.com/immutable-js/immutable-js/blob/main/CHANGELOG.md) - [Commits](immutable-js/immutable-js@v4.3.1...v4.3.4) --- updated-dependencies: - dependency-name: immutable dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Natalie Weizenbaum <[email protected]>

Closes sass#786

* Bump postcss from 8.4.27 to 8.4.31 Bumps [postcss](https://github.com/postcss/postcss) from 8.4.27 to 8.4.31. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.4.27...8.4.31) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * Document first-class mixins (sass#852) Closes sass#786 * Bump @types/seedrandom from 3.0.5 to 3.0.6 (sass#854) Bumps [@types/seedrandom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/seedrandom) from 3.0.5 to 3.0.6. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/seedrandom) --- updated-dependencies: - dependency-name: "@types/seedrandom" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump immutable from 4.3.1 to 4.3.4 (sass#858) Bumps [immutable](https://github.com/immutable-js/immutable-js) from 4.3.1 to 4.3.4. - [Release notes](https://github.com/immutable-js/immutable-js/releases) - [Changelog](https://github.com/immutable-js/immutable-js/blob/main/CHANGELOG.md) - [Commits](immutable-js/immutable-js@v4.3.1...v4.3.4) --- updated-dependencies: - dependency-name: immutable dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Natalie Weizenbaum <[email protected]>

Closes sass#786

* Bump postcss from 8.4.27 to 8.4.31 Bumps [postcss](https://github.com/postcss/postcss) from 8.4.27 to 8.4.31. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.4.27...8.4.31) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * Document first-class mixins (sass#852) Closes sass#786 * Bump @types/seedrandom from 3.0.5 to 3.0.6 (sass#854) Bumps [@types/seedrandom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/seedrandom) from 3.0.5 to 3.0.6. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/seedrandom) --- updated-dependencies: - dependency-name: "@types/seedrandom" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump immutable from 4.3.1 to 4.3.4 (sass#858) Bumps [immutable](https://github.com/immutable-js/immutable-js) from 4.3.1 to 4.3.4. - [Release notes](https://github.com/immutable-js/immutable-js/releases) - [Changelog](https://github.com/immutable-js/immutable-js/blob/main/CHANGELOG.md) - [Commits](immutable-js/immutable-js@v4.3.1...v4.3.4) --- updated-dependencies: - dependency-name: immutable dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Natalie Weizenbaum <[email protected]>

Document first-class mixins

b3ed1dc

Closes #786

nex3 requested a review from Goodwine September 28, 2023 19:46

nex3 mentioned this pull request Sep 28, 2023

Dynamic mixin invocation sass/sass#626

Closed

7 tasks

connorskees reviewed Sep 28, 2023

View reviewed changes

source/documentation/values/mixins.md Outdated Show resolved Hide resolved

nex3 added 9 commits September 28, 2023 13:44

Fix build issues

c676c97

Run tests against linked version of Dart Sass

bda5e34

Install Dart

dde90f1

Use clone-linked-repo with skip visible

cc5039f

Use the cloned output

4762e36

Install the protobuf for Dart Sass

212ca48

Add more missing Dart Sass steps

ae9a114

More fixes

9ab36f8

Run the shadow repo build action against pull requests

a41c2e6

This is necessary to ensure that it has access to the linked version of the Dart Sass repository.

Goodwine requested changes Sep 28, 2023

View reviewed changes

nex3 added 2 commits September 28, 2023 15:10

Fix shadow-repo-update

45d535e

Code review

6f59a2d

nex3 changed the title ~~Document first-class mixins~~ Document first-class mixins [skip netlify] Sep 28, 2023

nex3 requested a review from Goodwine September 28, 2023 22:35

Poke CI

75dde5f

sass deleted a comment from netlify bot Sep 28, 2023

Goodwine approved these changes Sep 28, 2023

View reviewed changes

source/documentation/values/mixins.md Show resolved Hide resolved

source/documentation/values/mixins.md Outdated Show resolved Hide resolved

nex3 added 2 commits September 28, 2023 15:44

Code review

4c39d3f

Use a released version of clone-linked-repo

7cdecf8

nex3 changed the title ~~Document first-class mixins [skip netlify]~~ Document first-class mixins Oct 6, 2023

nex3 added 3 commits October 5, 2023 17:06

Poke CI

504b362

Merge remote-tracking branch 'origin/main' into first-class-mixins

152e344

Add mixins to the documentation index

06de720

nex3 merged commit 5e05919 into main Oct 6, 2023

nex3 deleted the first-class-mixins branch October 6, 2023 21:20

pamelalozano16 pushed a commit that referenced this pull request Oct 9, 2023

Document first-class mixins (#852)

1c1589e

Closes #786

asaf400 pushed a commit to asaf400/ass-site that referenced this pull request Apr 18, 2024

Document first-class mixins (sass#852)

8cb868d

Closes sass#786

asaf400 pushed a commit to asaf400/ass-site that referenced this pull request Apr 18, 2024

Document first-class mixins (sass#852)

b6672cb

Closes sass#786

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Document first-class mixins #852

Document first-class mixins #852

nex3 commented Sep 28, 2023 •

edited

Loading

nex3 commented Sep 28, 2023

Goodwine Sep 28, 2023

nex3 Sep 28, 2023

Goodwine left a comment


		[mixin value]: /documentation/values/mixins

		If `$module` is `null`, this returns the mixin named `$name` defined in the

Document first-class mixins #852

Document first-class mixins #852

Conversation

nex3 commented Sep 28, 2023 • edited Loading

nex3 commented Sep 28, 2023

Goodwine Sep 28, 2023

Choose a reason for hiding this comment

nex3 Sep 28, 2023

Choose a reason for hiding this comment

Goodwine left a comment

Choose a reason for hiding this comment

nex3 commented Sep 28, 2023 •

edited

Loading