This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Rework test coverage facility w/istanbul #899
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a quick-and-dirty implementation. Works for me, the code could be nicer probably. It would be great to instrument |
|
I'm going to put this off til post 3.0.0. Could you please squash the commits? |
If there is no coverage at all we get an empty global variable and the lcov empty file may cause coveralls failure. Use mkdirp() to create lib-cov
|
Squashed to two, hopefully more meaningful commits. |
👍 |
|
Can't reopen this, pls follow up in #910 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reporting - hits/line ratio on index.js ~300
output
mocha and coveralls clients - wire reporters
directly via JavaScript